Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snippets: correctly escape backslashes in generated expressions #1995

Merged
merged 5 commits into from
Apr 11, 2022

Conversation

davidjgoss
Copy link
Contributor

🤔 What's changed?

When a generated cucumber expression contained a backslash (in order to escape, say, a parenthesis) the backslash would previously be treated as a noop escape in the context of a JavaScript string. Now we add another backslash to correctly escape it.

⚡️ What's your motivation?

Fixes #1324.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Apr 11, 2022

Coverage Status

Coverage increased (+0.003%) to 98.235% when pulling 641adf8 on fix/snippet-escapes into f26ce3e on main.

@davidjgoss davidjgoss merged commit 024911b into main Apr 11, 2022
@davidjgoss davidjgoss deleted the fix/snippet-escapes branch April 11, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated snippets with special characters are not correctly escaped.
3 participants